This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 3bc0f91 Fix checkstyle warnings
3bc0f91 is described below
commit 3bc0f9101e07c34f59c626687d8af5d358a26c7f
Author: Mark Thomas <[email protected]>
AuthorDate: Fri Dec 4 08:06:39 2020 +0000
Fix checkstyle warnings
---
java/org/apache/catalina/ssi/ExpressionParseTree.java | 4 ++--
java/org/apache/catalina/util/LifecycleMBeanBase.java | 1 -
java/org/apache/catalina/valves/rewrite/Substitution.java | 2 +-
java/org/apache/tomcat/websocket/WsFrameBase.java | 2 +-
test/org/apache/catalina/authenticator/TestFormAuthenticator.java | 2 +-
5 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/java/org/apache/catalina/ssi/ExpressionParseTree.java
b/java/org/apache/catalina/ssi/ExpressionParseTree.java
index 83da544..dd048c0 100644
--- a/java/org/apache/catalina/ssi/ExpressionParseTree.java
+++ b/java/org/apache/catalina/ssi/ExpressionParseTree.java
@@ -213,7 +213,7 @@ public class ExpressionParseTree {
/**
* A node in the expression parse tree.
*/
- private static abstract class Node {
+ private abstract static class Node {
/**
* @return {@code true} if the node evaluates to true.
*/
@@ -266,7 +266,7 @@ public class ExpressionParseTree {
/**
* A node implementation that represents an operation.
*/
- private static abstract class OppNode extends Node {
+ private abstract static class OppNode extends Node {
/**
* The left branch.
*/
diff --git a/java/org/apache/catalina/util/LifecycleMBeanBase.java
b/java/org/apache/catalina/util/LifecycleMBeanBase.java
index bfe2fec..4cb1b44 100644
--- a/java/org/apache/catalina/util/LifecycleMBeanBase.java
+++ b/java/org/apache/catalina/util/LifecycleMBeanBase.java
@@ -18,7 +18,6 @@
package org.apache.catalina.util;
import javax.management.MBeanServer;
-import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;
import org.apache.catalina.Globals;
diff --git a/java/org/apache/catalina/valves/rewrite/Substitution.java
b/java/org/apache/catalina/valves/rewrite/Substitution.java
index 26fc210..50d78db 100644
--- a/java/org/apache/catalina/valves/rewrite/Substitution.java
+++ b/java/org/apache/catalina/valves/rewrite/Substitution.java
@@ -25,7 +25,7 @@ import org.apache.catalina.util.URLEncoder;
public class Substitution {
- public static abstract class SubstitutionElement {
+ public abstract static class SubstitutionElement {
public abstract String evaluate(Matcher rule, Matcher cond, Resolver
resolver);
}
diff --git a/java/org/apache/tomcat/websocket/WsFrameBase.java
b/java/org/apache/tomcat/websocket/WsFrameBase.java
index c4108fe..fd8c4eb 100644
--- a/java/org/apache/tomcat/websocket/WsFrameBase.java
+++ b/java/org/apache/tomcat/websocket/WsFrameBase.java
@@ -912,7 +912,7 @@ public abstract class WsFrameBase {
protected abstract void resumeProcessing();
- private static abstract class TerminalTransformation implements
Transformation {
+ private abstract static class TerminalTransformation implements
Transformation {
@Override
public boolean validateRsvBits(int i) {
diff --git a/test/org/apache/catalina/authenticator/TestFormAuthenticator.java
b/test/org/apache/catalina/authenticator/TestFormAuthenticator.java
index cc488d8..9d4ca09 100644
--- a/test/org/apache/catalina/authenticator/TestFormAuthenticator.java
+++ b/test/org/apache/catalina/authenticator/TestFormAuthenticator.java
@@ -418,7 +418,7 @@ public class TestFormAuthenticator extends TomcatBaseTest {
* Encapsulate the logic needed to run a suitably-configured tomcat
* instance, send it an HTTP request and process the server response
*/
- private static abstract class FormAuthClientBase extends SimpleHttpClient {
+ private abstract static class FormAuthClientBase extends SimpleHttpClient {
protected static final String LOGIN_PARAM_TAG = "action=";
protected static final String LOGIN_RESOURCE = "j_security_check";
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
