https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #8 from Remy Maucherat <r...@apache.org> --- (In reply to Mark Thomas from comment #7) > I can't fund any EG discussion to support a requirement that the upgrade > header is set on the response before calling HttpServletRequest.upgrade(). > I'll see if can find a different way to get the protocol name. The javadoc in Tomcat for HttpServletRequest.upgrade is wrong, most likely things changed in the spec after it was added. In section 2.3.3.5, the spec says: "When an upgrade request is received, the servlet can invoke the HttpServletRequest.upgrade method, which starts the upgrade process. This method instantiates the given HttpUpgradeHandler class. The returned HttpUpgradeHandler instance may be further customized. The application prepares and sends an appropriate response to the client. After exiting the service method of the servlet, the servlet container completes the processing of all filters and marks the connection to be handled by the HttpUpgradeHandler . It then calls the HttpUpgradeHandler 's init method, passing a WebConnection to allow the protocol handler access to the data streams." So the actual upgrade happens when the Servlet is done, and nothing is fully set until then, no flush or commit happens when upgrade is called. Overall, the behavior of Tomcat is ok except for that use of the response header. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
