michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532264241



##########
File path: native/src/network.c
##########
@@ -316,6 +337,11 @@ TCN_IMPLEMENT_CALL(jint, Socket, bind)(TCN_STDARGS, jlong 
sock,
     TCN_ASSERT(sock != 0);
     TCN_ASSERT(s->sock != NULL);
     rv = (jint)apr_socket_bind(s->sock, a);
+
+    apr_pool_cleanup_register(s->pool, (const void *)s,

Review comment:
       OK, can you document the procedure in the case of a crash scenario?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to