DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41608>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41608

           Summary: The log level is different at same messages.
           Product: Tomcat 5
           Version: 5.5.20
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: [EMAIL PROTECTED]


I suggest a little message improvement.

The log level is different at same messages.
The message "Servlet.service() for servlet {0} threw exception" is 
output in eight places, but the message level is not same.

--org.apache.catalina.core.ApplicationDispatcher#invoke
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), rootCause);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);


--org.apache.catalina.core.StandardWrapperValve#invoke
container.getLogger().warn(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);
...
container.getLogger().warn(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);
...
container.getLogger().error(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), rootCause);
...
container.getLogger().error(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);

Are there any reasons for using getLogger().warn()?
I think it would be better that all of them use getLogger().error(...).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to