On Tue, Sep 15, 2020 at 3:26 PM Mark Thomas <ma...@apache.org> wrote:
> On 15/09/2020 14:12, Konstantin Kolinko wrote: > > пн, 14 сент. 2020 г. в 21:53, Mark Thomas <ma...@apache.org>: > >> > >> All, > >> > >> I'd like to proposed the following: > >> - Deprecated the JDBCRealm in 7.0.x, 8.5.x and 9.0.x > >> - Remove the JDBCRealm in 10.0.x > >> > >> The reasons for this are: > >> - The JDBCRealm is single threaded > >> - The DataSourceRealm is a better solution > >> > >> Thoughts? > > > > +1 > > > > Looking at documentation [1], it may be improved: > > > > a) Change ordering. It would be better to list DataSourceRealm first, > > followed by JDBCRealm.. (Currently JDBCRealm is the first one). > > I'll fix that. > > > b) Explicitly mention that JDBCRealm uses a single connection in its > > own documentation. (Currently documentation for DataSourceRealm > > mentions it, but the one for JDBCRealm itself does not). > > And that. > > > BTW, JNDIRealm also does not mention that it uses a single connection. > > Only by default and we could/should change that. How about changing the > default to, say, 10? > I didn't get any feedback, so it's only in Tomcat 10. It seems risky to backport if it hasn't been really tested. Rémy > > Mark > > > > > > [1] https://tomcat.apache.org/tomcat-9.0-doc/config/realm.html > > > > Best regards, > > Konstantin Kolinko > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
