https://bz.apache.org/bugzilla/show_bug.cgi?id=64715
Robert Rodewald <robert.rodew...@kopsis.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37434|0 |1 is obsolete| | --- Comment #8 from Robert Rodewald <robert.rodew...@kopsis.com> --- Created attachment 37438 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37438&action=edit Proposed patch for bug 64715 (second attempt) Changes to the first version: - added Contained interface to CallbackHandlerImpl and changed access logic - implemented check for Contained interface instead of different constructors in AuthenticatorBase - added test cases for the three supported Callbacks A questions that occurred to me: - Should we throw UnsupportedCallbackException for unsupported callbacks instead of ignoring them? This breaks compatibility but would enable the user to check for unimplemented callbacks. The use of the Contained interface is definitely a big plus. Thanks for the great feedback Mark. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org