kamnani edited a comment on pull request #340: URL: https://github.com/apache/tomcat/pull/340#issuecomment-675134104
1) "Configuration should not be via system properties unless absolutely necessary. In this instance configuration should probably be on the Host." - This configurations here affects the Java behavior, so the reason I mentioned it via the System Property route. Can you be more specific on that? 2) About the testing, I thought there are already pre-existing tests. Is there something more specific being scouted for - Always ready to write more testing code. 3) "It looks like simply deploying those 1000s of JARs into a shared class loader (or $CATALINA_BASE/lib) would achieve the same aim as the cache" - The cache here prevents the searching time from each of the Jars we know the resource might not even be present. If the cache is not there, there will be an overhead time to search the resource even in the Jars where they might not be present (Location really doesn't matter here). 4) I wonder why thread per core defaults to 1 instead of 2. 5) "I wonder to what extend the existing WebResources implementation can be tuned - particularly the cache - to achieve the same result." We have two optimizations on that part, one being in the WebResources and the other Is the JarFile handles. The bloom filter approach is the crucial part, since thats where we reduce the JarLookup time. 6) PR #333 => what we have is a very general approach and is independent of Presence or Absence of INDEX.LIST file. i am not too familiar with what they have proposed, but clearly they dont have the Bloom filter and thus relies heavily on the INDEX.LIST files for enhancing the resource lookup. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
