markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672771845
In reviewing this PR I've noticed another issue. The ETag obtained from the resource is unconditionally made strong before the comparison but that conversion should depend on `useWeakComparisonWithIfMatch`. I'm not convinced of the case for aligning the two methods and fixing this new issue looks like it will weaken that case. The test case change looks good. I'll add that, add a test for the new issue and then look at a fix for both issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
