ChristopherSchultz edited a comment on pull request #336:
URL: https://github.com/apache/tomcat/pull/336#issuecomment-670585072


   While the documentation may have been misleading, the implementation was 
correct: the stored credential is a literal `{SSHA}` + 
`base64(concat(sha1(concat(password, salt)), salt)`. I'm not sure this "fixes" 
anything; maybe it just adds another implementation.
   
   The salt length is not fixed at 20 characters. Tomcat doesn't generate new 
stored-credentials, so the salt for a `{SSHA}`-encoded credential is whatever 
is left over after the 20 bytes of the SHA1 hash has been removed from the 
front of the credential. (This is why the salt is somewhat confusingly placed 
at the end of the stored-credential.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to