https://bz.apache.org/bugzilla/show_bug.cgi?id=64645
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Jakub Moravec from comment #0)
> https://bz.apache.org/bugzilla/show_bug.cgi?id=49993, maybe the validation
> just needs to be enhanced.
+1
> We found out, that if JAVA_HOME is wrongly configured (for example if it
> points to JRE instead of JDK), the service.bat script won't fail, will skip
> to and return exit code 0.
JAVA_HOME should be able to point to either a JRE or JDK. Tomcat hasn't
required a JDK for a very long time.
> This is misleading, as the service was not installed because of wrongly
> set-up JAVA_HOME.
If true, I agree.
> Is it possible to provide better validation and make sure, that the exit
> code is not 0 in case the installation of the service fails?
Probably the best way to check for JAVA_HOME validity is to actually launch the
JVM with some trivial task (even just "java.exe --help") to make sure it
executes successfully, would you agree?
> I believe that swallowing of exceptions is not a good approach ;)
Do you believe there is an error being swallowed? Which one?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
