Hi Mark, On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas <ma...@apache.org> wrote:
> On 20/07/2020 18:20, Coty Sutherland wrote: > > This commit is problematic :( It's broken some projects that depend on > > Tomcat because now the tomcat-coyote.jar doesn't contain the > > org.apache.tomcat.util.net.jsse or > > org.apache.tomcat.util.modeler.modules packages which results in > > ClassNotFoundExceptions. I haven't seen any issues with other jars yet. > > The removal of those packages from the jar looks intentional, but we > > aren't providing the classes anywhere else for users to use which is > > causing problems. Thoughts? > > Those packages are still present. > It seems that removing the packages from the exported packages list actually removed them completely from the tomcat-coyote.jar (I decompiled it to look and they were not present, nor were they included in any other jars). > Do you mean those packages are no longer listed as exported in the OSGi > / JPMS meta-data? The following packages are currently listed as private > (and I assume the JPMS metadata is the same): > org.apache.tomcat.util.bcel > org.apache.tomcat.util.http.fileupload.impl > org.apache.tomcat.util.http.fileupload.util.mime > org.apache.tomcat.util.modeler.modules > org.apache.tomcat.util.net.jsse > > It should be fairly easy to get that fixed. > > Out of curiosity, what projects are broken? I'm surprised that something > has dependencies that deep into Tomcat's internals. Is this an OSGi > dependency or JPMS? > Thanks for looking into it, the fix you did was the same patch that I added yesterday ( https://src.fedoraproject.org/rpms/tomcat/c/a8c5ea85614dca66b492fe030a7e7cfc10cd52de?branch=master) :) I wish I'd proposed it upstream now, I just wasn't sure what the criteria was for not exporting the packages. The packages that were pointed out to me as broken are FreeIPA server ( https://bugzilla.redhat.com/show_bug.cgi?id=1857043) and Debian's libtomcat9-java package ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964433), both with different CNFEs.
