On Wed, Jul 8, 2020 at 5:10 PM Christopher Schultz < ch...@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Rémy, > > On 7/8/20 10:35, Rémy Maucherat wrote: > > On Wed, Jul 8, 2020 at 4:26 PM Christopher Schultz > > <ch...@christopherschultz.net > > <mailto:ch...@christopherschultz.net>> wrote: > > > >>> Clearly, no, with multiple elements, the digester rules added > >>> to ContextRuleSet would be something like (in addition to the > >>> unchanged ones for CookieProcessor): > >> > >> digester.addObjectCreate(prefix + "Context/CookieProcessor", > >> > >>> "org.apache.tomcat.util.http.Rfc6265CookieProcessor", > >> "className"); digester.addSetProperties(prefix + > >> "Context/CookieProcessor"); digester.addSetNext(prefix + > >> "Context/CookieProcessor", "setCookieProcessor", > >> "org.apache.tomcat.util.http.CookieProcessor"); > >> > >> digester.addObjectCreate(prefix + > >>> "Context/CookieProcessor/SameSiteCookie", > >> > >>> "org.apache.tomcat.util.http.SameSiteCookie", > >> "className"); digester.addSetProperties(prefix + > >>> "Context/CookieProcessor/SameSiteCookie"); > >> digester.addSetNext(prefix + > >>> "Context/CookieProcessor/SameSiteCookie", > >> "addSameSiteCookie", > >> "org.apache.tomcat.util.http.SameSiteCookie"); > >> > >>> If the bean class is > >>> org.apache.tomcat.util.http.SameSiteCookie. > > > > So you are okay with: > > > > digester.addSetProperties(prefix + > > "Context/CookieProcessor/SameSiteCookie"); > > > > > > But not with: > > > > digester.addCallMethod(prefix + > > "Context/CookieProcessor/SameSiteCookie/Cookie"); > > > > ? > > > > > > The digester works best with beans so I don't see what is so > > surprising about this. > > What's surprising is that you are -1 to what I see as an improvement > to Tomcat without much in the way of disruption. I think it's pretty > clean. > > Would proposing an actual patch help, or will you still be -1 on > anything other than a complicated "sameSiteCookies" string value which > needs to be unpacked by Tomcat code rather than using standard XML > element/attribute syntax? > The digester rules I posted add a new SameSiteCookie element. I only mentioned a complex sameSiteCookies attribute syntax once (I considered it would be better for API compatibility; the CookieProcessor API should not break in Tomcat 9 when things are backported, or the feature would be limited to Tomcat 10) but I didn't mention it again since you did not like it. Rémy > > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl8F4eMACgkQHPApP6U8 > pFhhkxAAgQdr7vdbaO0qeWHPbKdh2hcy5NuKMOozOWaERHowTsx3yv9rHfiVKaXG > gti6mzcLIqXMPiMbqCE+fYpOCAfqJsAtjjg3zWs9Sh1vk7HOrOmZ7V2s5bbvjeqe > zCcrgdC+PKMO9Up/OWdwfAj8oARhtYFfTQfgoEiT61ElDYNnCU+swuDh9CZwJpv0 > HzQ+U+kEEYpgZrawzuk4xCvOSk+HKNAcG5LDphYgLUGUNg3Eq7tlvzDSQ/PX1Hbd > VFHipCk4pDcRgvFq9GYK3b81QAlxcizFOW129+CPRSYINg1ztomv1Gqw+JXiwnG5 > YCcd6LaBT0fn3SldtE/rWNZResK3qnQG0aeAFvdl1qzzWvOSMMzyuJB7XMxkRlTZ > lo3w7nJ9dJ4RdtjSshuBj6vrjFxqmAexbhy+e/aWmjKjjuEPl9oZx7jYbGKg79ER > Bn+6nkUEP7YxBMSg9LTqFJvzGw6PPplunn6MTef7PZYpj9qwJh5xg2AXGZqrndmD > XaowT4zNASfguq34BxmACWkqQrc6+3Wvdutafz7yvr0yxrvZz2+pmT6fJ9C6nBQO > 4xyqxYRUa+Bt+4b2ppAzrVIJ+egk+6tbcUiqxMvbH1RV7GD+rwyEI5DRtv1RsTiw > lCI9Y4K3R2a1pEN/0nArQrkBAzEttlxTPoZ9eJyUxsuVXtLor6g= > =lUHF > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
