https://bz.apache.org/bugzilla/show_bug.cgi?id=63545
--- Comment #5 from Christopher Schultz <ch...@christopherschultz.net> ---
I'm skeptical of the usefulness of this patch, but I won't stop anyone from
applying it.
I have a short review of the patch as presented.
Request.java: I am -1 on this change
- public Principal getPrincipal() already exists
AbstractAccessLogValve.java:
- use Request.getPrincipal instead of (unnecessary)
Request.getRemoteUserRoles()
- There is no need for a StringBuilder to buffer role names; simply append
directly to the existing buffer
- new Character(',').charValue() is unnecessary
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
