KangZhiDong commented on issue #279: URL: https://github.com/apache/tomcat/pull/279#issuecomment-617485732
> What is the basis for this change? > While the thread is in `wait()`, `notify()` should only be called if one of the conditions in the surrounding `if(...)` is no longer true. I'd expect the change in this PR to make performance marginally worse, not better. i think because "while (sendfileRunning && sendfileCount < 1 && addS.size() < 1)" in outer layer check again,so it can use "if" there ，do not need check again in synchronized block ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
