markt-asf commented on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-616400683
Thanks for the updates. Exactly the sort of thing I had in mind.
Looking at the updated code, I'm wondering whether a slightly wider
refactoring makes sense. Something like:
- for each thread where the web application class loader is the context
class loader (this code is already present)
- if using executor, stop the executor (which should interrupt the
thread) else interrupt the thread
- add the thread to a list of threads that should be stopping
- wait until all the threads that should be stopping have stopped or a set
amount of time passes (currently we use 2 seconds)
- call stop on any threads still running
i.e. interrupt all threads, wait for all threads, stop all remaining threads
rather than interrupt, wait, stop one thread at a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
