smarkwal opened a new pull request #2: Bugfix: EESpecProfile for Tomcat: Exclude Java packages not migrated to Jakarta URL: https://github.com/apache/tomcat-jakartaee-migration/pull/2 The following Java packages have not been migrated to the new Jakarta workspace: - javax.annotation.processing (part of module [java.compiler](https://docs.oracle.com/en/java/javase/14/docs/api/java.compiler/module-summary.html)) - javax.transation.xa (module [java.transaction.xa](https://docs.oracle.com/en/java/javase/14/docs/api/java.transaction.xa/module-summary.html)) Classes from these packages are still part of the JDK - even in Java 11 and greater. They have not been migrated to jakarta.* packages. The current pattern for EESpecProfile.TOMCAT does not take this into account. As a result, the migration tool has renames classes from these packages. Java classes with dependencies on these packages then have cause NoClassDefFoundErrors. Even Tomcat 10.0.0-M4 makes use of these Java packages (in their original javax.* namespace). ecj-4.15.jar has dependencies on ... - javax.annotation.processing.Filer - javax.annotation.processing.FilerException - javax.annotation.processing.Messager - javax.annotation.processing.ProcessingEnvironment - javax.annotation.processing.Processor - javax.annotation.processing.RoundEnvironment tomcat-dbcp.jar has dependencies on ... - javax.transaction.xa.XAException - javax.transaction.xa.XAResource - javax.transaction.xa.Xid This pull request fixes this issue by adding to "negative lookahead" sequences into the regex pattern for the Tomcat migration profile. PS: I'm not a Java/Jakarta EE expert, but I guess that the same fix should be applied to the EE migration profile?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
