On 06/04/2020 12:41, Rémy Maucherat wrote: > On Mon, Apr 6, 2020 at 1:36 PM <r...@apache.org > <mailto:r...@apache.org>> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: > new 14406c0 Use a separate mbean type for SocketProperties > 14406c0 is described below > > commit 14406c0b49c29fd05dd8f707b62ece38429e16f8 > Author: remm <r...@apache.org <mailto:r...@apache.org>> > AuthorDate: Mon Apr 6 13:36:10 2020 +0200 > > Use a separate mbean type for SocketProperties > > A subType seems to not be handled well by some tools so it's > likely more > robust to avoid it. Inspired by BZ64314, and similarly I cannot > see the > mbean in visualvm. > > > Should I backport this ? > Although it is a breaking change (in theory), the mbean name used > doesn't seem very reliable in tools.
I don't recall why I used a subType for that. I think in this case the risk of breakage is outweighed by the benefits of making the MBean accessible to more/most tools. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org