markt-asf commented on issue #252: 8.5.x URL: https://github.com/apache/tomcat/pull/252#issuecomment-607806850 Thanks. While I'm not merging this specific PR I do want to assure you that the PR was very helpful in resolving this. Having a concrete proposal to work from is much easier than developing one from scratch. The end result isn't that different from what you proposed. I opted for `null` rather than dummy request objects as it simplified things a little. The only other difference was the changes to handle the deprecation so we end up with a single `generateHeader()` in Tomcat 10 onwards. Thanks again for your contribution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
