Hi, On Thu, Mar 26, 2020 at 11:23 PM Rémy Maucherat <r...@apache.org> wrote:
> On Thu, Mar 26, 2020 at 9:16 PM Christopher O'Connell < > coconnel...@gmail.com> wrote: > >> The Tomcat release version 7.0.100 introduced a bug that prevented >> ServiceLoaders from being started. This was fixed by the ticket: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=64191 (Thank you for >> the fix) >> >> This problem ended up causing an application I was working on from >> running correctly. In an attempt to resolve, I tried turning up >> logging but there does not appear to be any logging in this section of >> the code, error or otherwise. >> >> Would it be possible to add additional logging, specifically in the >> WebappServiceLoader.java class? I'd be willing to submit code to >> address this concern. >> > > -1 > Adding useless verbose logging just to reassure you that there's no bug in > the container is quite pointless. SCI processing is not something that is > complex, and if your SCI is found you can log there. > The benefit of having the log statement (as DEBUG) in Tomcat's code base is that the developer can see all SCI impls being used in the application, not just "mine SCI". And often "mine SCI" is not really mine but provided by some web framework like Spring MVC, RestEasy, etc. If those have their own log statements then I could enable them one by one. But it is possible that they won't have such too. Is there any harm of having such log statement in Tomcat ? It loads those classes at application start time so it is not a hot path. My 2c. Martin > > Rémy > > >> >> Thanks, >> >> Chris >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >>
