On Mon, Mar 23, 2020 at 11:11 AM Mark Thomas <ma...@apache.org> wrote:
> > - Reduce instances of setters and getters for the same property existing
> > on an object and its parent. This may require new objects to be exposed
> > via JMX.
> > Fixed enough ?
>
> From memory, this was primarily on the Connectors. That is certainly a
> lot better. I'd like to review things before closing this one out.
>
There's indeed a problem on Connector, but I don't see how to fix it.
Ex:
public void setMaxPostSize(int maxPostSize) {
this.maxPostSize = maxPostSize;
setProperty("maxPostSize", String.valueOf(maxPostSize));
}
Both Catalina and Coyote need to access the value. The alternative would be
to have the Catalina code use getProperty, which would be both uglier and
slower.
Rémy
