-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Michael,
On 3/9/20 10:20, Michael Osipov wrote: > Folks, > > I have been recently reviewing some downstream changes in > tomcat-native. Can someone explain me why we install headers files > along with .pc file? > >> . ├── bin ├── include │ ├── ssl_private.h │ ├── tcn_api.h │ >> ├── tcn_version.h │ └── tcn.h └── lib ├── libtcnative-1.a ├── >> libtcnative-1.la ├── libtcnative-1.so -> libtcnative-1.so.0.2.23 >> ├── libtcnative-1.so.0 -> libtcnative-1.so.0.2.23 ├── >> libtcnative-1.so.0.2.23 └── pkgconfig └── tcnative-1.pc > > Why is bin dir created although we don't install anything into > it?! > > ssl_private.h shouldn't definitively be there. What about the rest? > Does it really make sense to install them at all? Can/Are there > (be) any C users who compile and link against libtcnative? It seems strange, but yes, we do have downstream libtcnative users. I have no idea why they are using our wrappers. Occasionally, we get a bug report about some basically-never-used function in libtcnative, like the File API [1]. We should probably formally deprecate like 50% of libtcnative with an eye toward throwing out all that code. Even better, we should drop the APR connectors which would discard even more code. Even better than THAT, we should look at how to direct-call OpenSSL/LibeSSL without having to use our own wrappers and completely throw-away libtcnative entirely. I think this is "Project Panama" and is something that evidently is actually arriving. Java 12 had some of the initial work shipped with it, and Java 13 has continued that effort. This might be a great GSOC project for a student to tackle. - -chris [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=52627 -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl5ms6AACgkQHPApP6U8 pFhfUhAAy9xhvs9REchE3aCnRqT/KyvnwYX70+W3+P/xX9mIckgQmh5Cee2WR9sY X4DFM5UwnGX3ukVjj97irqLExupaN1tfvRZJop42EoN7yRm5mucxGO/xRt9fDCIj tobzyrGptquODdpSflnTLXKmTtNWoyI/0nxsF9U7upfA2d2qgFc2ob0N1twBOWxx e94LQbcWJ5y1VDQlsiqluEQu+W8kyCGoE/8vKgcy4EtLgaF8Pt6dKrBp69PauYDE RnQ9VLqD0CmI7hU2+Knzzg7+k7yMSY7qoa2GZVJYfk8rssrUld0MySXdAOGxgZ99 v5lsNUO5uzCszDZFWKKJegaCKNUC5sSz7bCwYtG/UFnWv0gp3fHVnHstfS/fgEO7 U1nTtlW99YGBKLDEPLNsiPN+aBu5R7o11Ur0R5GrZUSKE3WMs945RCBOKU02RmxQ 88218E09IeXUSLEgO0oBYYt/2ZbhSuPyFY0n4S2+X/QrS4ZOrw315NxHcy3DNEYP 93ZXzsXEoRFUOTp4sc4KMV0e0tflZIuEcS0KKtqM5AqtiOwXmKdxtCuVe5ssc/NY B09ooEXQvgzGU13IrlqJQn1kEvXZpLlnFEjeE5wGhv8le2h3hzMeDENAWIPffuNZ YBzEkWRD3EKG4Kqd725pc9taPy7uIZkye/D9oCM/SBu1z38XFcc= =DH++ -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
