On 04/03/2020 17:27, Christopher Schultz wrote:
> Mark,
>
> On 3/3/20 09:36, ma...@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git
>> repository.
>
>> markt pushed a commit to branch master in repository
>> https://gitbox.apache.org/repos/asf/tomcat.git
>
>
>> The following commit(s) were added to refs/heads/master by this
>> push: new 4ad0a71 BZ 64190 Add 'proper' ms support to
>> OneLineFormatter. 4ad0a71 is described below
>
>> commit 4ad0a71bc11de50e0fe23fc38e6e67f134aa0589 Author: Mark Thomas
>> <ma...@apache.org> AuthorDate: Tue Mar 3 14:36:08 2020 +0000
>
>> BZ 64190 Add 'proper' ms support to OneLineFormatter.
<snip/>
>> int insertStart = cachedTimeStamp.indexOf('#');
>
> Should the literal '#' be the DateFormatCache.msecPattern constant
> instead? It's unlikely to change, but it's slightly less "magic
> character"-ish if you reference the constant.
Yes, that would be better.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
