On 28/02/2020 14:51, Konstantin Kolinko wrote:
> 1). The diff block above - the same attribute is documented twice?
Not sure how I missed that. I'll get the duplicate removed.
> 2). I think that this attribute should be mentioned in security-howto.
I'll add something.
> 3). Why force a <nobr> here? I think this will make documentation less
> readable.
I was neutral on it so I left it. Happy to remove it.
> 4). The same <nobr> question here.
And the same answer :)
> 5). In one of source files: (copy-pasting a previous fragment from the diff):
>
> + /**
> + * Return whether authentication information shall be persisted or not.
> + *
> + * @return {@code true}, if authentication information shall be
> persisted;
> + * {@code false} otherwise
> + */
> + private boolean isPersistAuthentication() {
> + if (manager instanceof ManagerBase) {
> + return ((ManagerBase) manager).getPersistAuthentication();
> + }
> + return false;
> + }
>
> 5). Why the getter names are inconsistent?
>
> Here "isPersistAuthentication()" is implemented as a call to
> "getPersistAuthentication()".
I'll make them consistent (get)
Thanks for the review.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
