rmaucher commented on a change in pull request #246: OpenSSLEngine improvements
to guard against multiple shutdown() calls triggered by construction exception
and finalize() later
URL: https://github.com/apache/tomcat/pull/246#discussion_r381180960
##########
File path: java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
##########
@@ -141,7 +142,7 @@
private boolean handshakeFinished;
private int currentHandshake;
private boolean receivedShutdown;
- private volatile boolean destroyed;
+ private final AtomicBoolean destroyed = new AtomicBoolean(false);
Review comment:
Try without the AtomicBoolean but ssl and networkBIO should be final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
