On Wed, Feb 12, 2020 at 8:02 PM Mark Thomas <ma...@apache.org> wrote:
> On 12/02/2020 18:53, Rémy Maucherat wrote: > > <snip/> > > > I think I remember I had problems already before the async API with > > those weird tests doing zero length writes in that TCK :( > > > > I may make changes to the fix, since: > > - I notice arrayHasData doesn't use offset and length, it's better if it > > does > > - With NIO arrayHasData is also used for a read, I suppose it's not a > > problem but I'll change it anyway > > Thanks for the review. > > For read, won't arrayHasData() check if there is any buffer space to > write into? Might need to change the method name in that case. maybe > arrayRemaining() ? > So that looks ok. I'll add use of the offset/length shortly, it won't hurt. Rémy
