On 23/01/2020 10:29, Michael Osipov wrote: <snip/>
> Design questions: > * Shall this remain a listener or do we want to introduce a new > interface for that? If yes, how should it look like? Given the use cases (could apply at various levels) a LifecycleListener looks like a reasonable design choice to me. I don't see the need for an additional interface (although I could be persuaded if someone else makes an argument for one) > * Where can this element be placed? Only in context.xml? Also in > server.xml? If yes, at which level are contexts available to be > modified? Can this be placed in server.xml at all? LifecycleListener can be placed on most elements so it gives plenty of flexibility. > If it remains as a listener, I would be willing to donate my listener to > the Tomcat codebase and add support for file:// or other stuff required. Fantastic. Thank you. Take a look at the ConfigFileLoader. All Tomcat config should be loaded through that. > From my understanding, the mapping source can be arbitrary: inline, > database, file, etc. Agreed. Mark > > [0] https://bz.apache.org/bugzilla/show_bug.cgi?id=55477 > [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=55477#c14 > [2] https://bz.apache.org/bugzilla/show_bug.cgi?id=55477#c15 > [3] > http://mo-tomcat-ext.sourceforge.net/xref/net/sf/michaelo/tomcat/extras/listeners/PropertiesRoleMappingListener.html > > > Please bear with me since I am a slow responder. > > Michael > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
