-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 1/20/20 2:25 PM, Mark Thomas wrote: > On 20/01/2020 17:21, Mark Thomas wrote: >> On 20/01/2020 17:08, Christopher Schultz wrote: >>> On 1/20/20 12:01 PM, ma...@apache.org wrote: >> >> <snip/> >> >>>> Add encryption as the first option to secure a cluster --- >> >> <snip/> >> >>> I could have sworn I added this, already. Thanks for doing it. >> >> I'm looking at back-porting the Interceptor to 7.0.x. I've got >> everything done apart from GCMParameterSpec which is new in Java >> 7. >> >> I don't suppose you've looked into this previously and know if >> there is a Java 6 equivalent? It would save me the time to >> research it. >> >> If not, I'll make it a Java 7+ feature with JreCompat. > > Java 6 doesn't support GCM. JreCompat it is. You may not need it: I checked, and the GCMParameterSpec class isn't referenced except in the GCMEncryptionManager class, which will only be loaded if the user specifically requests GCM block-cipher mode. So maybe you could just leave it alone and allow CNFE to occur on Java 7. Or, if you want a nicer error message, you can catch CNFE (or similar) or explicitly check the Java version and print a nice error message. But don't require Java 7 for the EncryptInterceptor in general. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl4nHnYACgkQHPApP6U8 pFg60BAAyd5I50nyPL4IGtovVLAbKgEaWSO0MUgoBQ4KbVErt863lQkqShjAoQHV pk72r/FM/Fw2iOqXlmGprO1gHpIqlJXuJVCEBaBvff5cJ8qKT319zf5v03i+/KD3 1vlzieoFnx7dv+GFWNIvg9PbKBMiJQdjLvik+4R+FOO7UADBdyixM5TldWcYlClV j533WOuXSsHL9Y8moMA3CntEGBJR6/CCRVXuC+jqlWmOkcxO7xurDg7dKHbYwBDH OLAnq0l3UhgZ60b7sP/0wqNnxf4iGWTrARAc2DfhVuTVmnX5w0BeNci7VueAPIMA tIL8zs8fG2rRiUrAasLCUIhuWswkSxpg3qn3Xh1KkVJpCZD73/V97Z4Fn98VC+Xx +PmhsV+R9n820ggbNXbyextAmdT/AQIbzXik/ixRBaEHKo7W5EqYEPfH9p3o7Vbl s8Xn19xMATKkylq/3b0GYbME3JR9yO6faeFi/cIMVFdkEqE3/ILt+lJO/d5h5atP BAB01a+IKYHd/7qOLCsk8TOUGYGfCuSgJgOozImnhsQgj3Mm1U6gIeEQuFQ6tZMc Aac2nL5n8Sx9rxjf/Ib99ETqaLk+n9Cejgr/FoISw3v5bnl4cRS3dc6LthAM3RId pSsTCXt1edbuors9z3fv6tFRYu99ywtzE0r6Mx79CtXoYnCaHzI= =IRI4 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
