+1 to align both, really reduces diff in tests and prod Le mer. 4 déc. 2019 à 19:23, Mark Thomas <ma...@apache.org> a écrit :
> On 04/12/2019 18:11, Christopher Schultz wrote: > > Mark, > > > > On 12/4/19 13:02, Mark Thomas wrote: > >> Hi all, > > > >> I was looking at this as an off-shoot of looking at BZ 63985. > > > >> Currently, there are 844 MIME mappings in conf/web.xml that are > >> not included in Tomcat.DEFAULT_MIME_MAPPINGS. Fixing it isn't too > >> hard. The 844 figure comes from a unit test I could easily tweak to > >> generate the code needed to paste in to add these. > > > >> The question is, do we want to keep these in sync? > > > >> If the answer is yes I can get this fixed fairly quickly and add > >> some unit tests to ensure that they stay in sync. > > > >> Thoughts? > > > > What about reading them from a file instead of hard-coding them? > > > > That same file can be used at build-time to generate the actual > > contents of the conf/web.xml that we ship as a binary. > > We could. I'm not convinced the savings of only maintaining a single > file going forwards is worth the extra work to do that. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
