markt-asf commented on a change in pull request #227: Unit test FileStore utility methods URL: https://github.com/apache/tomcat/pull/227#discussion_r352784475
########## File path: java/org/apache/catalina/session/FileStore.java ########## @@ -187,9 +187,9 @@ public void clear() throws IOException { // Build and return the list of session identifiers List<String> list = new ArrayList<>(); int n = FILE_EXT.length(); - for (int i = 0; i < files.length; i++) { - if (files[i].endsWith(FILE_EXT)) { - list.add(files[i].substring(0, files[i].length() - n)); + for (String file1 : files) { + if (file1.endsWith (FILE_EXT)) { + list.add (file1.substring (0, file1.length () - n)); } Review comment: Same here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org