72er-de commented on issue #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222#issuecomment-556292570 I think the constructor has a lot of lines of code and the idea to extract setter could be help to read the code. So I have ordered back the extracted methods so that we can compare with apache/master and perhaps I found a theoretical issue here: ``` // TODO: Check this behaviour, if scratchDir == null // then EmbeddedServletOptions is not correctly initiated! // Could only happen if System.getProperty("java.io.tmpdir") // is not set. -> unusual exception? if (scratchDir == null) { log.fatal(Localizer.getMessage("jsp.error.no.scratch.dir")); return; } ``` [EmbeddedServletOptions.zip](https://github.com/apache/tomcat/files/3871042/EmbeddedServletOptions.zip)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
