-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Michael,
On 11/9/19 05:58, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this > push: new ccd6518 Fix test fallout of BZ 63905 ccd6518 is > described below > > commit ccd6518024ab4f8c0add42eb2b20941a6b237f5d Author: Michael > Osipov <micha...@apache.org> AuthorDate: Sat Nov 9 11:35:22 2019 > +0100 > > Fix test fallout of BZ 63905 --- > test/org/apache/coyote/http2/TestHttp2InitialConnection.java | 2 > +- 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/test/org/apache/coyote/http2/TestHttp2InitialConnection.java > b/test/org/apache/coyote/http2/TestHttp2InitialConnection.java > index 2157eae..a362a19 100644 --- > a/test/org/apache/coyote/http2/TestHttp2InitialConnection.java +++ > b/test/org/apache/coyote/http2/TestHttp2InitialConnection.java @@ > -127,7 +127,7 @@ public class TestHttp2InitialConnection extends > Http2TestBase { int statusHeaderLength = sm > .getString("errorReportValve.statusHeader", "", "") > .getBytes(StandardCharsets.UTF_8).length; - int len = > 1073 + serverInfoLength + statusHeaderLength * 2; + int > len = 708 + serverInfoLength + statusHeaderLength * 2; Why not fix this properly with: int len = org.apache.catalina.util.TomcatCSS.TOMCAT_CSS.getBytes(StandardCharsets. UTF_8).length + serverInfoLength + statusHeaderLength * 2; ?? It's just going to happen again when someone changes the CSS. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl3MM/kACgkQHPApP6U8 pFhkUw//VSKrL5DFR+mtxdDlzsPmnMWYJQ6hKNfuuq6borShwI9smOIBaUmnBWWu jmA+qWJ0zoQaWwOsc0mmixDzMO1Ck5/B5HVdWcwtSlif1YUK7MSEqlCIELkwvqgA TYxiA6CLf4SQc7X3cipZvhqJQ+5tVBjS9Irc3tQ86p6Ojly3h83c3gAAKncYXLWO nI07wIUI5uC8jh/s5lmq0fUcIvmWgwzU4vOEH2ZvCPDnfja5HYfp3JOMPkwUXD43 /FP/dewd/trDy2vYBu0StKn6Ft0fhVQzXCvMDzWUVdyMJGHUQ+gh3D4rCwpRs0p4 X1lI6pogK0GNE1mtokNcqtkIg6W4z8QWGyKK0i2zFsk3gaVLoV5K0Bhoao3LUvZ/ oFSJnQaYdhe7QQrftkXw0NlEdMKkt6kHVMbiV/GSlvcL8ERH8mBlyIUfEKLIb43n 3iXxaJqTnFXYjYqiRiZezZxHhB2OyEs3eCshxP4lxSXmL8HQOEHnAvwadW16xwA4 WDYaL31AeYqxl206ku2fQFCm5Lb+Gt6EEI9wHXc9g+oLgzcw8aLo4zr/0FgWq5US TxcjgNfJqSF65a86oLvwx1BE545FPFctgck/lXVcKTVYgeDsfgr6V8S2cif0812H 3Tf5RtHVsmUEsML2+Ge3kIfObZioqCCaeBwdQxLE4NNkKHgfKzs= =RvAv -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
