-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Michael,
On 11/8/19 17:49, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this > push: new 69602cb BZ 63905: Clean up Tomcat CSS 69602cb is > described below > > commit 69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1 Author: Michael > Osipov <micha...@apache.org> AuthorDate: Thu Nov 7 22:21:27 2019 > +0100 > > BZ 63905: Clean up Tomcat CSS > > Remove duplication in Tomcat CSS and align its usage which applies > to ErrorReportValve, and several servlets. Also update update > incorrect documentation as well. --- > java/org/apache/catalina/servlets/DefaultServlet.java | 16 > ++++++++++------ java/org/apache/catalina/util/TomcatCSS.java > | 16 +++++++--------- webapps/docs/changelog.xml > | 3 +++ webapps/docs/config/valve.xml | 5 > ++--- 4 files changed, 22 insertions(+), 18 deletions(-) > > diff --git a/java/org/apache/catalina/servlets/DefaultServlet.java > b/java/org/apache/catalina/servlets/DefaultServlet.java index > c217cf6..2883f5c 100644 --- > a/java/org/apache/catalina/servlets/DefaultServlet.java +++ > b/java/org/apache/catalina/servlets/DefaultServlet.java @@ -1815,14 > +1815,18 @@ public class DefaultServlet extends HttpServlet { > String rewrittenContextPath = rewriteUrl(contextPath); > > // Render the page header - sb.append("<html>\r\n"); + > sb.append("<!doctype html><html>\r\n"); + /* TODO Activate > this as soon as we use smClient with the request locales + > sb.append("<!doctype html><html lang=\""); + > sb.append(smClient.getLocale().getLanguage()).append("\">\r\n"); + > */ Thank you for this. Even though it's not yet active, It's good to have it in there as a reminder for the future. Do you think it's worth having any \r\n characters in here? Seems like just a waste of space on the wire. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl3MMisACgkQHPApP6U8 pFikpBAAkolAV7dx+erYxAYAjs6jIsRMIdZhjGkRJ+K57b5f1A0UlaimBT5embIW bYrCDZEpV+1yYW3Ii61ZNZD59gkCVh5eyCxE72s+M3AWvWvgAOepCoj9nbiw3kXq ac0LCQ/bB2qmLIBc2NGCACYxRNRtmB3aGAC1j9Jnr6MsYGRLIWOyueVKRDVhJjvm F/F3PDQIy6TWvMXKfgu+JeE38ArB7qVg2UFI7SYTRVw6gvvi/XnngOio4Io8uFv2 Q2iAkeWu0maeCbjDtKOq3YVLiiKXbGsThx/tLITKYk4V12x/TFflpYd5fYFUuMoJ Mw9HdID3BaIBHOwq3Q4J5t9ocZfT01jsIbjLhD9QIrIqrLCp7PbwzE2DPD4tQlDV mFk6UI3FI+4SbtJMEy3QdwB4Oj44xogIclwVwUfDx07WrfSLwUmOOwhceLyDkgO+ 9azj71HggvovDx0ROQXLzzved3qZIP23N4nNgpDJcj+kP/+0laR6crcfLIGLWR2f z0ejIjwB0lhTxeheYOPCnGjACcN6h4Dm5+uu08g/QxmCObnzZpORdPJuW2PSlaYy Dn0h0cuz/vRg/Z+4nEve9GBWX7COZNiuOqXwEwoO5OKro2Fzvwj5o3ZqbM7MGRmj 2WViKkuhedYEHFRlfEeZ182/z7OczDX8irbPdYl2k8Vn41O/00Y= =sEMq -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
