On Thu, Nov 7, 2019 at 11:11 AM <r...@apache.org> wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: > new 5f4d5b3 Better cleanup in setSocketOptions > 5f4d5b3 is described below > > commit 5f4d5b357f4388149845fa96d87930d6f664e252 > Author: remm <r...@apache.org> > AuthorDate: Thu Nov 7 11:10:41 2019 +0100 > > Better cleanup in setSocketOptions > > Since the connections map is updated here, the socket must be removed > from it if things go wrong before the wrapper processing begins. Also > call free() on the channel (and then discard it) since this wouldn't be > done anywhere and could leak direct memory in some cases. >
Note: APR doesn't need this change since it doesn't have a channel needing cleanup, and its closeSocket method should do the remove from the connections map. Rémy
