https://bz.apache.org/bugzilla/show_bug.cgi?id=63833

Guoxiong Li <lgxbs...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36823|0                           |1
        is obsolete|                            |

--- Comment #3 from Guoxiong Li <lgxbs...@gmail.com> ---
Created attachment 36824
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36824&action=edit
A new draft patch for review.

Hi Phil Steitz, think your for your reminding. I update my patch. 

The new patch add null check in method destroyObject. I don't modify method
activateObject, validateConnection and passivateObject because I consider that
a patch should minumize and avoid too many changes.

When the reviewer agree to the change and the test method in this path, I will
add another patch which changes the method activateObject, validateConnection
and passivateObject. I will squash all the commit and submit a pull request
which make it easy to merge.

Please review the patch. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to