On 09/10/2019 21:35, Michael Osipov wrote: > Am 2019-10-09 um 18:55 schrieb Mark Thomas: >> On 09/10/2019 16:48, Michael Osipov wrote: >>> and >>> >>>> Testcase: testMultipleHostHeaders took 1,385 sec >>>> FAILED >>>> expected:<...content-length]-[112[7] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1127] >>>> 1-EndOfStream >>>>> but was:<...content-length]-[112[8] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1128] >>>> 1-EndOfStream >>>>> >>>> junit.framework.AssertionFailedError: >>>> expected:<...content-length]-[112[7] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1127] >>>> 1-EndOfStream >>>>> but was:<...content-length]-[112[8] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1128] >>>> 1-EndOfStream >>>>> >>>> at >>>> org.apache.coyote.http2.Http2TestBase.validateHttp2InitialResponse(Http2TestBase.java:129) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.Http2TestBase.http2Connect(Http2TestBase.java:111) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.TestHttp2InitialConnection.testMultipleHostHeaders(TestHttp2InitialConnection.java:55) >>>> >>>> >>>> >>>> Testcase: testValidHostHeader took 0,143 sec >>>> Testcase: testNoHostHeader took 0,185 sec >>>> FAILED >>>> expected:<...content-length]-[112[7] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1127] >>>> 1-EndOfStream >>>>> but was:<...content-length]-[112[8] >>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] >>>> 1-HeadersEnd >>>> 1-Body-1128] >>>> 1-EndOfStream >> >> Hmm. Those are odd. I wonder why the content length is off. Some sort of >> line ending issue maybe? > > I assume so. I will look into it.
Thanks. >>> and the last one is a locale issue with the resource bundles: >>> >>>> 08-Oct-2019 11:24:51.852 INFORMATION [main] >>>> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler >>>> ["http-apr-127.0.0.1-auto-24-26939"] >>>> ------------- ---------------- --------------- >>>> >>>> Testcase: testHeaderLimits100x32 took 1,391 sec >>>> Testcase: testHeaderLimits101x32 took 0,411 sec >>>> Testcase: testHeaderLimits1x128k took 0,416 sec >>>> FAILED >>>> >>>> Expected: match to regular expression pattern >>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*] >>>> but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3], >>>> Gesamt-Header-Größe zu groß]" >>>> junit.framework.AssertionFailedError: >>>> Expected: match to regular expression pattern >>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*] >>>> but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3], >>>> Gesamt-Header-Größe zu groß]" >>>> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) >>>> at >>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:259) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:170) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:164) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:158) >>>> >>>> >>>> at >>>> org.apache.coyote.http2.TestHttp2Limits.testHeaderLimits1x128k(TestHttp2Limits.java:138) >>>> >> >> We should find a way to fix that one. > > Either exclude the resource JARs from the classpath or change the code. > Shall I file an issue here? Yes please. I was thinking of using StringManager to obtain the i18n version of the string for the test. I haven't look to see whether that is practical or not. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
