This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new d8f6235 Remove unnecessary code
d8f6235 is described below
commit d8f62357bf2f34c375702f0f44f083abb222c61e
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Aug 14 17:47:08 2019 +0100
Remove unnecessary code
All currently supported versions of Windows support large pollsets
---
java/org/apache/tomcat/util/net/AprEndpoint.java | 14 ++------------
webapps/docs/changelog.xml | 9 +++++++++
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/AprEndpoint.java
b/java/org/apache/tomcat/util/net/AprEndpoint.java
index b0a14bf..4c1ca49 100644
--- a/java/org/apache/tomcat/util/net/AprEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AprEndpoint.java
@@ -1790,25 +1790,15 @@ public class AprEndpoint extends AbstractEndpoint<Long>
implements SNICallBack {
private volatile boolean sendfileRunning = true;
/**
- * Create the sendfile poller. With some versions of APR, the maximum
- * poller size will be 62 (recompiling APR is necessary to remove this
- * limitation).
+ * Create the sendfile poller.
*/
protected void init() {
pool = Pool.create(serverSockPool);
int size = sendfileSize;
if (size <= 0) {
- size = (OS.IS_WIN32 || OS.IS_WIN64) ? (1 * 1024) : (16 * 1024);
+ size = 16 * 1024;
}
sendfilePollset = allocatePoller(size, pool,
getConnectionTimeout());
- if (sendfilePollset == 0 && size > 1024) {
- size = 1024;
- sendfilePollset = allocatePoller(size, pool,
getConnectionTimeout());
- }
- if (sendfilePollset == 0) {
- size = 62;
- sendfilePollset = allocatePoller(size, pool,
getConnectionTimeout());
- }
desc = new long[size * 2];
sendfileData = new HashMap<>(size);
addS = new ArrayList<>();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 0175601..775d1d7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -45,6 +45,15 @@
issues do not "pop up" wrt. others).
-->
<section name="Tomcat 8.5.45 (markt)" rtext="in development">
+ <subsection name="Coyote">
+ <changelog>
+ <scode>
+ Remove the code in the sendfile poller that ensured smaller pollsets
+ were used with older, no longer supported versions of Windows that
+ could not support larger pollsets. (markt)
+ </scode>
+ </changelog>
+ </subsection>
</section>
<section name="Tomcat 8.5.44 (markt)" rtext="release in progress">
<subsection name="Catalina">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
