-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 6/24/19 05:58, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch 8.5.x in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > commit 4ec3d26396e4d8804629d31fa2459eb1401bcf44 Author: Mark Thomas > <ma...@apache.org> AuthorDate: Mon Jun 24 10:54:54 2019 +0100 > > Back-port spotbugs fixes --- > java/org/apache/catalina/servlets/WebdavServlet.java | 12 > ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java > b/java/org/apache/catalina/servlets/WebdavServlet.java index > 5ce1678..1ad0f97 100644 --- > a/java/org/apache/catalina/servlets/WebdavServlet.java +++ > b/java/org/apache/catalina/servlets/WebdavServlet.java @@ -18,6 > +18,7 @@ package org.apache.catalina.servlets; > > import java.io.IOException; import java.io.InputStream; +import > java.io.Serializable; import java.io.StringReader; import > java.io.StringWriter; import java.io.Writer; @@ -909,7 +910,7 @@ > public class WebdavServlet extends DefaultServlet { return; } > > - LockInfo lock = new LockInfo(); + LockInfo lock = > new LockInfo(maxDepth); > > // Parsing lock request > > @@ -2357,11 +2358,18 @@ public class WebdavServlet extends > DefaultServlet { /** * Holds a lock information. */ - private > class LockInfo { + private static class LockInfo implements > Serializable { + + private static final long > serialVersionUID = 1L; Shouldn't this be something more random? - -chris > + + public LockInfo(int maxDepth) { + > this.maxDepth = maxDepth; + } The "maxDepth" member does not seem to be used. Is this part of a separate commit? - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl0SsIAACgkQHPApP6U8 pFgQEA//QHc0xrJTCCxeRcAHtU8oypEXO9FGzVtj5JjB0uDFtlCTNIkPG+30nicH vNUX+Ivir+WCV3RMvMHvNzSnQgGW+nKlNTC3pNhdjLaEM0kRIspdJDPobWORABzS yyxcmNYy5YzeW8EiglmFhiiGogVhjxdGKumsDhS6beFdvuR3j0Yiux/1+4/4WPpP 6ueB2Yl5G21h3CxwwNWMHL9NJDx0UggFNBFCues6ftMDymaNs7FkAXxaCgeZCVlN B49gakEmElVvQc4m8P39vhhk4bF1ix5BS4jvdV5H370xY62mhSJBMmqGHO/0jPpd ZhDH8dqrMCgjcQWxwHEnEGm/qc76qE7dremFrYqNZPH+Xy21xZZ9PWEJXovmOkbV 5C8h+FZH8ifV0LTZpAiICdI+s7r4BB9sF7f/Jx5ZVgDxzRdpaYj+3HBmqs47mD/v ViJEgc2VTtQSuUiUesmRE94UaOrDPu1wG+/TyRkFEVZ72ZftgSVuuybj6uRjujQ8 fQePd1s+8Vj8MXDFcO7qO2Hn/v/XTvx2y3kxEE+xtFLHR6c5ZfdbZqrvaqtZAIkv 8Ub8dcogWKY0LazfrJm7FD06ypUxr7w0LvZ7+vvz6bSp+R/YR2eDK4ySzIMvyah1 +ZE0l9dLFViJaPPISGdHyCYzTwWcxQSXYHRWaXyhAujPYt1vvQ4= =RFG5 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
