ChristopherSchultz commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503220181 Ah, okay. I was only looking at the diff and it wasn't clear that code was in two different locations. As for the "extra" `ROLLBACK`, you could always maintain a flag to avoid a second call. I'm sure the driver shouldn't be trying to "know" whether or not a `COMMIT` or `ROLLBACK` will be a no-op, and every programmer should expect that calling `rollback()` or `commit()` will result in the corresponding command *always* being sent to the server. So if you want to be completely tidy, you could maintain a little state for that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
