[tomcat] 02/04: lock() should be outside try {...}

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 51cbfd346a98bd426307a7f0fa93c0a9371eac60
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Jun 11 18:27:01 2019 +0100

    lock() should be outside try {...}
---
 java/javax/el/Util.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/javax/el/Util.java b/java/javax/el/Util.java
index cc5a631..e7e20d2 100644
--- a/java/javax/el/Util.java
+++ b/java/javax/el/Util.java
@@ -120,8 +120,8 @@ class Util {
 
         if (factory == null) {
             final Lock writeLock = cacheValue.getLock().writeLock();
+            writeLock.lock();
             try {
-                writeLock.lock();
                 factory = cacheValue.getExpressionFactory();
                 if (factory == null) {
                     factory = ExpressionFactory.newInstance();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org