On 07/06/2019 12:13, Rémy Maucherat wrote: > On Fri, Jun 7, 2019 at 12:57 PM <ma...@apache.org > <mailto:ma...@apache.org>> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: > new 42e2ef2 Follow-up to e967bbc. Provide a sync but on a > different object. > 42e2ef2 is described below > > commit 42e2ef20c75b63941b2f0bade520963da711b836 > Author: Mark Thomas <ma...@apache.org <mailto:ma...@apache.org>> > AuthorDate: Fri Jun 7 11:55:29 2019 +0100 > > Follow-up to e967bbc. Provide a sync but on a different object. > > As identified by BZ 61740, headers must be written in the same order > they are generated because the compression algorithm used maintains > state across multiple request/response pairs. > > Sync on a dedicated object to ensure that this is the case. > > > My tests still work with that lock object change, so a local lock was > enough here.
That is good news. The prioritisation tests aren't showing the errors they were previously either so it does look there was just the one deadlock issue to fix. Back to thinking about how to tackle prioritisation before the connection flow control window is exhausted... Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
