This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2eb2d84 Add fake parameters on two tests which (rarely) fail for me
2eb2d84 is described below
commit 2eb2d843f68b9b224f5d8457f340c9bd1e9240c9
Author: remm <[email protected]>
AuthorDate: Tue Jun 4 13:17:44 2019 +0200
Add fake parameters on two tests which (rarely) fail for me
5_3 has a timeout problem.
Async flush has a window update manager waitForNonBlocking ISE problem.
This should make problems far easier to detect.
---
test/org/apache/coyote/http2/TestAsyncFlush.java | 8 ++++++++
test/org/apache/coyote/http2/TestHttp2Section_5_3.java | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/test/org/apache/coyote/http2/TestAsyncFlush.java
b/test/org/apache/coyote/http2/TestAsyncFlush.java
index 8de4c54..3c4373b 100644
--- a/test/org/apache/coyote/http2/TestAsyncFlush.java
+++ b/test/org/apache/coyote/http2/TestAsyncFlush.java
@@ -28,6 +28,8 @@ import javax.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import org.apache.catalina.Context;
import org.apache.catalina.Wrapper;
@@ -46,8 +48,14 @@ import org.apache.catalina.startup.Tomcat;
* while the specification allows this to work - it doesn't require that
* it does work.
*/
+@RunWith(Parameterized.class)
public class TestAsyncFlush extends Http2TestBase {
+ @Parameterized.Parameters
+ public static Object[][] data() {
+ return new Object[10][0];
+ }
+
private static final int BLOCK_SIZE = 1024;
@Test
diff --git a/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
b/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
index a0bcbaf..64e86de 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_5_3.java
@@ -18,6 +18,8 @@ package org.apache.coyote.http2;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
/**
* Unit tests for Section 5.3 of
@@ -29,8 +31,14 @@ import org.junit.Test;
* Note: Unit tests for the examples described by each of the figures may be
* found in {@link TestAbstractStream}.
*/
+@RunWith(Parameterized.class)
public class TestHttp2Section_5_3 extends Http2TestBase {
+ @Parameterized.Parameters
+ public static Object[][] data() {
+ return new Object[10][0];
+ }
+
// Section 5.3.1
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
