On 22/05/2019 07:37, Keiichi Fujino wrote: <snip/>
> It seems that the recordAllActions flag is not set in the newly created > DeltaRequest. I reworked the patch multiple times and forgot that for this iteration. Thanks for catching it. I've fixed this with an additional commit. > There are duplicated codes in DeltaManager#requestCompleted and > DeltaSession#getDiff. > It may be able to call getDiff method in the DeltaManager#requestCompleted. Good call. Fixed. > The same is true for DeltaManager#deserializeAndExecuteDeltaRequest and > applyDiff. I couldn't see this. There are some similarities but don't see how this could work. The unit tests passed so I plan to commit (and back-port) this unless there are objections. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
