markt-asf commented on issue #162: Add support for same-site cookie attribute URL: https://github.com/apache/tomcat/pull/162#issuecomment-492644191 Thanks for the updates. I have a few comments on the updated PR: - You can reduce the code duplication by using CookieProcessorBase - SameSiteCookies looks to be a good candidate for an Enum unless I am missing something - Feel free to add a changelog entry for this
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
