On 10/05/2019 20:02, Rémy Maucherat wrote: > On Fri, May 10, 2019 at 8:01 PM Mark Thomas <ma...@apache.org> wrote: > >> I've just pushed a fix. The tests seem more stable now locally but I am >> going to keep running them. Thanks for the pointer. The issue was >> obvious as soon as I read your email. >> >> Given the issue has been there for a while, unless anyone objects I am >> going to go ahead with the releases. >> > > Excellent. Gitbox seems out of sync again [I hope nobody starts using it, > or we'll end up running into trouble ...],
Gitbox is currently down so at least nothing can get out of sync. > so no CI run for now, but I'm > certain it's the right fix [it works for me locally and I could "reliably" > reproduce the issue with "test-only" and enough runs of the 5_3 test]. My > original hack doesn't look so bad retrospectively since it is equivalent to > waiting for the right notify, but it's a good thing to drop weird hacks. I still see some failures but they are genuine timeouts due to what looks like GC pauses. I've disabled debug logging again. That might help. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
