On Sat, May 4, 2019 at 12:13 PM Rémy Maucherat <r...@apache.org> wrote:
> On Sat, May 4, 2019 at 12:52 AM Mark Thomas <ma...@apache.org> wrote: > >> The proposed Apache Tomcat 9.0.20 release is now available for voting. >> >> The major changes compared to the 9.0.19 release are: >> >> - The useAsyncIO boolean attribute on the Connector element value now >> defaults to true. >> >> - Stack traces written by the OneLineFormatter are fully indented. The >> entire stack trace is now indented by an additional TAB character. >> >> - Various HTTP/2 improvements and stability fixes. >> >> Along with lots of other bug fixes and improvements. >> >> For full details, see the changelog: >> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.20/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-1211/ >> The tag is: >> https://github.com/apache/tomcat/tree/9.0.20 >> 4202de2f20c29f38a6a700133f9724745c7306d8 >> >> The proposed 9.0.20 release is: >> [ ] Broken - do not release >> [X] Stable - go ahead and release as 9.0.20 >> >> There is a suspicious failure in a recent testsuite run though ( > https://ci.apache.org/projects/tomcat/tomcat9/logs/4285/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt) > but for me at least it's good. We'll see. > > https://ci.apache.org/projects/tomcat/tomcat9/logs/4288/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt #4288 with debug reproduced it, it seems to be a not-that-rare situation introduced by the stream timeout: 04-May-2019 13:25:21.576 FINE [http-nio2-127.0.0.1-auto-2-exec-7] org.apache.coyote.http2.Stream.close Connection [1], Stream [17], Reset sent due to [ENHANCE_YOUR_CALM] 04-May-2019 13:25:21.576 FINE [http-nio2-127.0.0.1-auto-2-exec-7] org.apache.coyote.http2.Http2AsyncUpgradeHandler.sendStreamReset Connection [1], Stream [17], Error [ENHANCE_YOUR_CALM], Message [Timeout waiting for client to increase flow control window to permit stream data to be written], RST (closing stream) 04-May-2019 13:25:21.577 FINE [main] org.apache.coyote.http2.Http2Parser.validateFrame Connection [-1], Stream [17], Frame type [RST], Flags [0], Payload size [4] 04-May-2019 13:25:21.577 INFO [main] org.apache.coyote.http2.TestHttp2Section_5_3.testWeighting 17-RST-[11] So it could be related to the new write timeout, not 100% certain yet. Rémy