On 17/04/2019 19:22, Christopher Schultz wrote:
> On 4/17/19 12:55, ma...@apache.org wrote:
<snip/>
>> Close the resource we no longer need if we know how to do so +
>> if (result instanceof AutoCloseable) { + try
>> { + ((AutoCloseable) result).close(); +
>> } catch (Exception e) { + // Ignore +
>> } + }
>
> Any concrete objections to logging these exceptions?
No.
> Swallowing
> exceptions is almost never a good practice, and if they are happening
> it's probably worth knowing something is amiss.
Yeah. I know. I was short on time (still am) and calling close and not
logging the exception was better than what was there before. Going back
over these and adding some log message is on my TODO list. I'm not going
to object if someone beats me to it ;)
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
