jchobantonov commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481860226 > But these lines are all in the same transaction, no? Yes they are - there is no need to use local variable as well - it is the same - if you forget to set invocationSuccess variable to correct value you could forget to set the local variable as well > OK, but why not set `invocationSuccess = true;` at line 405, for example, instead of repeating it in each catch block? The only difference I see in these blocks is the log message (with the exception of that last block of course, which sets the flag to `false`). because if you to have another thread trying to access the LockOutRealm and you put the 'invocationSuccess = true' on line 405 you could just change the failed invocation e.g. invocationSuccess from false to true on line 405 to only put the variable back to false when the next attempt fails again
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
