isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481853982 > To reduce the number of changed lines and opportunities for mistakes, there could be a local flag for success which is copied to the global flag after each transaction. But these lines are all in the same transaction, no? > initialize to true means that it is available and when we detect it is not then we change that to be not available OK, but why not set `invocationSuccess = true;` at line 405, for example, instead of repeating it in each catch block? The only difference I see in these blocks is the log message (with the exception of that last block of course, which sets the flag to `false`). https://github.com/apache/tomcat/blob/39f55d8c6f5658a8ea730ebbf8cc1680194c5a48/java/org/apache/catalina/realm/JAASRealm.java#L405
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
