https://bz.apache.org/bugzilla/show_bug.cgi?id=63324
--- Comment #5 from Martin L <martin.leman...@willhaben.at> ---
Thanks for your feedback.

I've applied your suggestions, but needed to customize them a bit, depending on
the branch.
There are 3 PRs, one for 7.0.x, one for 8.5.x and one for master.

In 7.0.x the test setup looks a slightly bit different, and you need to
implement both interface methods of HttpSessionBindingListener
https://github.com/apache/tomcat/pull/156


In 8.5.x I couldn't use the signature Map.remove(key, value). 
I was getting a `method remove in interface Map<K,V> cannot be applied to given
types; clientIdSessionId.remove(clientIdentifier, event.getSession().getId());`
when running the tests. 
So I needed to check for the same value in an extra if.
https://github.com/apache/tomcat/pull/155

In master is the "cleanest" solution.
https://github.com/apache/tomcat/pull/154

Do you want me to upload all 3 patches here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to