On 3/19/2019 6:34 AM, Mark Thomas wrote:
On 19/03/2019 04:04, Igal Sapir wrote:
On 3/18/2019 1:28 PM, Mark Thomas wrote:
All,
I started to work on cleaning up the DBCP generics warnings in 7.0.x
before I remembered what "fun" it was when I did this for DBCP2.
While some of it is straight-forward, some of it requires some
refactoring. From memory, the refactoring did fix a few bugs along
the way.
Given that the changes aren't trivial, I wanted to get some feedback
from the community as to the best approach here. Options include:
a) No nothing
b) Fix the trivial generics
c) Fix all the generics including any necessary refactoring
I actually enjoy refactoring code so I'd be happy to help with (b) or
(c) if either is chosen.
Thanks. I'll leave the thread open for a few days to see what folks
think.
I have a lot of the trivial fixes sat in a local branch so it will be
the 'fun' ones that will need to be completed.
Sounds good.
Working on tasks like that will make me more familiar with the source
code and prepare me for tackling bigger issues in the future, so it can
be beneficial beyond just completing the tasks.
Best,
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
